Added a "no smoothing" option to GivTCP

9 comments started 2023-01-26 last 2023-01-29
Home Automation
#1 Riscy

I've made a very light-touch mod to GivTCP so that you can specify None for the data smoothing option. Config looks like this:

Smoothing Config for None

I thought this would be useful for those people who are digging-deep into the firmware behaviour, and want access to an unadjusted set of data.

If there's sufficient interest then I'll contact Britkat about getting it merged into their existing Add On as a version update.

#2 TheDragon (GivEnergy)

Riscy

Where is your repo?

#3 Riscy

TheDragon (GivEnergy) You're right, I've forked it. Happy to give the details, providing that you're OK treating it as beta (irony suppressed) because I only did it yesterday?

Also - in terms of etiquette and deferral to britkat's excellent work - I don't want my fork becoming publicly used because I think britkat's is the de-facto repository. So I'd want it merged back before wider use.

#4 TheDragon (GivEnergy)

Riscy
Ok understood.

I will wait out, I tend to use low now for the smoothing

#5 Riscy

@Britkat Ping me if you're interested - should I just propose a PR into your fork?

#6 Riscy

@Britkat PR done, hope it looks OK.

Added some tweaks which might help robustness, too.

Feel free to leave comments. Nobody should ever expect to get a PR through a Review without them!

J
#7 jake

@Riscy i've pulled your work into my fork and have it running, pr looks good, thanks for the contrib, looking forward to it getting merged 🙂

#8 Riscy

jake Appreciate you checking it over, thanks a lot. Code is always better with more eyes-on!

B
#9 Britkat

Thanks, have seen this, will merge with my next update to allow no smoothing